diff options
| author | Lv Yunlong <lyl2019@mail.ustc.edu.cn> | 2021-03-10 00:31:27 -0800 |
|---|---|---|
| committer | Ard Biesheuvel <ardb@kernel.org> | 2021-03-19 07:44:27 +0100 |
| commit | 9ceee7d0841a8f7d7644021ba7d4cc1fbc7966e3 (patch) | |
| tree | 91df4aa2a0987806b89ba4b033591dec45327bbb | |
| parent | 483028edacab374060d93955382b4865a9e07cba (diff) | |
| download | linux-stericsson-9ceee7d0841a8f7d7644021ba7d4cc1fbc7966e3.tar.gz | |
firmware/efi: Fix a use after bug in efi_mem_reserve_persistent
In the for loop in efi_mem_reserve_persistent(), prsv = rsv->next
use the unmapped rsv. Use the unmapped pages will cause segment
fault.
Fixes: 18df7577adae6 ("efi/memreserve: deal with memreserve entries in unmapped memory")
Signed-off-by: Lv Yunlong <lyl2019@mail.ustc.edu.cn>
Signed-off-by: Ard Biesheuvel <ardb@kernel.org>
| -rw-r--r-- | drivers/firmware/efi/efi.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/drivers/firmware/efi/efi.c b/drivers/firmware/efi/efi.c index df3f9bcab581c4..4b7ee3fa9224ff 100644 --- a/drivers/firmware/efi/efi.c +++ b/drivers/firmware/efi/efi.c @@ -927,7 +927,7 @@ int __ref efi_mem_reserve_persistent(phys_addr_t addr, u64 size) } /* first try to find a slot in an existing linked list entry */ - for (prsv = efi_memreserve_root->next; prsv; prsv = rsv->next) { + for (prsv = efi_memreserve_root->next; prsv; ) { rsv = memremap(prsv, sizeof(*rsv), MEMREMAP_WB); index = atomic_fetch_add_unless(&rsv->count, 1, rsv->size); if (index < rsv->size) { @@ -937,6 +937,7 @@ int __ref efi_mem_reserve_persistent(phys_addr_t addr, u64 size) memunmap(rsv); return efi_mem_reserve_iomem(addr, size); } + prsv = rsv->next; memunmap(rsv); } |