diff options
| author | Benjamin Poirier <bpoirier@nvidia.com> | 2022-07-11 08:52:53 +0900 |
|---|---|---|
| committer | Stephen Hemminger <stephen@networkplumber.org> | 2022-07-18 09:46:24 -0700 |
| commit | 2cb76253ed852559a4f2b315f5e23457a15d71e5 (patch) | |
| tree | 28202d651872a119327aeb91ce314bd122aff63c | |
| parent | afdbb0204a5872f1f76058a0db5a529b1f0c8de7 (diff) | |
| download | iproute2-2cb76253ed852559a4f2b315f5e23457a15d71e5.tar.gz | |
mptcp: Fix memory leak when getting limits
When running the command `ip mptcp limits` under valgrind, it reports
32,768 bytes in 1 blocks are definitely lost in loss record 1 of 1
at 0x483F7B5: malloc (vg_replace_malloc.c:381)
by 0x17A0BC: rtnl_recvmsg (libnetlink.c:838)
by 0x17A3A1: __rtnl_talk_iov.constprop.0 (libnetlink.c:1040)
by 0x17B864: __rtnl_talk (libnetlink.c:1141)
by 0x17B864: rtnl_talk (libnetlink.c:1147)
by 0x16837D: mptcp_limit_get_set (ipmptcp.c:436)
by 0x1174CB: do_cmd (ip.c:136)
by 0x116F7C: main (ip.c:324)
Free the answer obtained from rtnl_talk().
Fixes: 7e0767cd862b ("add support for mptcp netlink interface")
Suggested-by: Ido Schimmel <idosch@nvidia.com>
Reviewed-by: Ido Schimmel <idosch@nvidia.com>
Signed-off-by: Benjamin Poirier <bpoirier@nvidia.com>
Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
| -rw-r--r-- | ip/ipmptcp.c | 10 |
1 files changed, 7 insertions, 3 deletions
diff --git a/ip/ipmptcp.c b/ip/ipmptcp.c index 54817e467..ce62ab9a4 100644 --- a/ip/ipmptcp.c +++ b/ip/ipmptcp.c @@ -436,9 +436,13 @@ static int mptcp_limit_get_set(int argc, char **argv, int cmd) if (rtnl_talk(&genl_rth, &req.n, do_get ? &answer : NULL) < 0) return -2; - if (do_get) - return print_mptcp_limit(answer, stdout); - return 0; + ret = 0; + if (do_get) { + ret = print_mptcp_limit(answer, stdout); + free(answer); + } + + return ret; } static const char * const event_to_str[] = { |