diff options
| author | Po-Hsu Lin <po-hsu.lin@canonical.com> | 2022-12-29 13:41:06 +0800 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2022-12-30 07:37:26 +0000 |
| commit | 1573c6882018f69991aead951d09423ce978adac (patch) | |
| tree | 9fd3fd3e97612ee9cb2c65288e402a16e2b791db | |
| parent | a512807c24bc561f5892ae05abdf360482fb3fe2 (diff) | |
| download | pci-1573c6882018f69991aead951d09423ce978adac.tar.gz | |
selftests: net: fix cmsg_so_mark.sh test hang
This cmsg_so_mark.sh test will hang on non-amd64 systems because of the
infinity loop for argument parsing in cmsg_sender.
Variable "o" in cs_parse_args() for taking getopt() should be an int,
otherwise it will be 255 when getopt() returns -1 on non-amd64 system
and thus causing infinity loop.
Link: https://lore.kernel.org/lkml/CA+G9fYsM2k7mrF7W4V_TrZ-qDauWM394=8yEJ=-t1oUg8_40YA@mail.gmail.com/t/
Signed-off-by: Po-Hsu Lin <po-hsu.lin@canonical.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
| -rw-r--r-- | tools/testing/selftests/net/cmsg_sender.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/tools/testing/selftests/net/cmsg_sender.c b/tools/testing/selftests/net/cmsg_sender.c index 75dd83e39207bd..24b21b15ed3fb0 100644 --- a/tools/testing/selftests/net/cmsg_sender.c +++ b/tools/testing/selftests/net/cmsg_sender.c @@ -110,7 +110,7 @@ static void __attribute__((noreturn)) cs_usage(const char *bin) static void cs_parse_args(int argc, char *argv[]) { - char o; + int o; while ((o = getopt(argc, argv, "46sS:p:m:M:d:tf:F:c:C:l:L:H:")) != -1) { switch (o) { |