aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorJakub Kicinski <jakub.kicinski@netronome.com>2019-03-12 15:27:17 -0700
committerJakub Kicinski <jakub.kicinski@netronome.com>2019-03-19 15:50:19 -0700
commit9616e1b26dbe9153f1af5fd4b1bacad6a30d0e23 (patch)
tree7e21b7e3430aef31551dbf8d2cb594472ed6d98e
parente9ce4b30636dbfd15fe542fdff88eb2e3992ca63 (diff)
downloadlinux-wip-nn-hstat.tar.gz
f bug on hstat -iwip-nn-hstat
Signed-off-by: Jakub Kicinski <jakub.kicinski@netronome.com>
-rw-r--r--net/core/hstats.c7
1 files changed, 3 insertions, 4 deletions
diff --git a/net/core/hstats.c b/net/core/hstats.c
index 79e8e40ede2b8..5de8107c1573f 100644
--- a/net/core/hstats.c
+++ b/net/core/hstats.c
@@ -9,8 +9,6 @@
#include <net/hstats.h>
#include <net/netlink.h>
-/* TODO: bug on hstat -i $ifc */
-
/* We deploy a simple stack-based dumper to walk the hierarchies.
* This is the documentation format for quick analysis of the state machine:
*
@@ -631,7 +629,8 @@ __rtnl_get_link_hstats(struct sk_buff *skb, const struct net_device *const_dev,
struct rtnl_hstat_req req;
ssize_t ret;
- if (!dev->netdev_ops || !dev->netdev_ops->ndo_hstat_get_groups)
+ if (!const_dev->netdev_ops ||
+ !const_dev->netdev_ops->ndo_hstat_get_groups)
return -ENODATA;
dumper = hstat_dumper_init(skb, const_dev, dev, prividx);
@@ -641,7 +640,7 @@ __rtnl_get_link_hstats(struct sk_buff *skb, const struct net_device *const_dev,
memset(&req, 0, sizeof(req));
req.dumper = dumper;
- ret = dev->netdev_ops->ndo_hstat_get_groups(dev, &req);
+ ret = const_dev->netdev_ops->ndo_hstat_get_groups(const_dev, &req);
if (ret < 0)
goto exit_dumper_destroy;
ret = req.err;