diff options
author | Joern Engel <joern@logfs.org> | 2011-12-22 16:46:38 -0800 |
---|---|---|
committer | Joern Engel <joern@logfs.org> | 2011-12-22 16:46:38 -0800 |
commit | 0597b18d8b043a473731cf99c7b1c01470ba3858 (patch) | |
tree | 25f3d992670170bfae8237a3c09dac18ee4fd14a | |
parent | d16953325ec77034645a5ba1a07ce8c6eaedede4 (diff) | |
download | cancd-0597b18d8b043a473731cf99c7b1c01470ba3858.tar.gz |
make do_output() void
It only ever returned 0 - making the return code fairly pointless.
Signed-off-by: Joern Engel <joern@logfs.org>
-rw-r--r-- | cancd.c | 15 |
1 files changed, 5 insertions, 10 deletions
@@ -279,20 +279,19 @@ static int open_socket() return 0; } -/* Only return nonzero if fatal */ -static int do_output(const char *buf, int len, struct sockaddr_in *addr, socklen_t socklen) +static void do_output(const char *buf, int len, struct sockaddr_in *addr, socklen_t socklen) { int fd, rc, tot; char *name, *tmp, *dir; name = get_path(&addr->sin_addr); if (!name) - return 0; + return; tmp = strdup(name); if (!tmp) { syslog(LOG_ERR, "Unable to allocate memory while logging to \"%s\"", name); - return 0; + return; } dir = dirname(tmp); @@ -300,7 +299,7 @@ static int do_output(const char *buf, int len, struct sockaddr_in *addr, socklen free(tmp); if (rc) - return 0; + return; fd = open(name, O_WRONLY | O_APPEND | O_CREAT, 0600); if (fd < 0) @@ -320,8 +319,6 @@ static int do_output(const char *buf, int len, struct sockaddr_in *addr, socklen close(fd); } free(name); - - return 0; } static int set_blocking(int blocking) @@ -412,9 +409,7 @@ static int run() break; } /* For now, we process one at a time */ - rc = do_output(buf, rc, &from, fromlen); - if (rc) /* do_output() better not return error if nonfatal */ - break; + do_output(buf, rc, &from, fromlen); } syslog(LOG_INFO, "Shutting down"); |