trace-cmd record: Fix filtering when using set_event_pid

When set_event_pid exists, trace-cmd uses it for filtering tasks. A commit
that updates the pid filtering was not updated to handle excludes of the
tracing, and they were added too, causing more to be filtered than what
should have been.

Fixes: a5923c5c9f81 ("trace-cmd: Filter out specific pids")
Signed-off-by: Steven Rostedt (VMware) <rostedt@goodmis.org>

1 files changed, 7 insertions, 1 deletions

diff --git a/trace-record.c b/trace-record.c
index bd60892a..1b55043e 100644
--- a/trace-record.c
+++ b/trace-record.c
@@ -2042,11 +2042,16 @@ static void update_pid_filters(struct buffer_instance *instance)
 	str = filter;
 
 	for (p = filter_pids; p; p = p->next) {
+		if (p->exclude)
+			continue;
 		len = sprintf(str, "%d ", p->pid);
 		str += len;
 	}
 
-	len = len_filter_pids + nr_filter_pids;
+	if (filter == str)
+		goto out;
+
+	len = str - filter;
 	str = filter;
 	do {
 		ret = write(fd, str, len);
@@ -2056,6 +2061,7 @@ static void update_pid_filters(struct buffer_instance *instance)
 		len -= ret;
 	} while (ret >= 0 && len);
 
+ out:
 	close(fd);
 }