aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorPavan Holla <pholla@chromium.org>2023-06-07 19:33:26 +0000
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2023-06-13 12:16:07 +0200
commit92c9c3baad6b1fd584fbabeaa4756f9b77926cb5 (patch)
tree843f34a145c9bedbe8e630b195a048d0fb06077a
parentc4a8bfabefed706bb9150867db528ceefd5cb5fe (diff)
downloadlinux-92c9c3baad6b1fd584fbabeaa4756f9b77926cb5.tar.gz
usb: typec: Fix fast_role_swap_current show function
The current implementation mistakenly performs a & operation on the output of sysfs_emit. This patch performs the & operation before calling sysfs_emit. Fixes: 662a60102c12 ("usb: typec: Separate USB Power Delivery from USB Type-C") Cc: stable <stable@kernel.org> Reported-by: Benson Leung <bleung@chromium.org> Signed-off-by: Pavan Holla <pholla@chromium.org> Reviewed-by: Heikki Krogerus <heikki.krogerus@linux.intel.com> Reviewed-by: Benson Leung <bleung@chromium.org> Message-ID: <20230607193328.3359487-1-pholla@chromium.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-rw-r--r--drivers/usb/typec/pd.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/usb/typec/pd.c b/drivers/usb/typec/pd.c
index 0bcde1ff4d39b..8cc66e4467c48 100644
--- a/drivers/usb/typec/pd.c
+++ b/drivers/usb/typec/pd.c
@@ -95,7 +95,7 @@ peak_current_show(struct device *dev, struct device_attribute *attr, char *buf)
static ssize_t
fast_role_swap_current_show(struct device *dev, struct device_attribute *attr, char *buf)
{
- return sysfs_emit(buf, "%u\n", to_pdo(dev)->pdo >> PDO_FIXED_FRS_CURR_SHIFT) & 3;
+ return sysfs_emit(buf, "%u\n", (to_pdo(dev)->pdo >> PDO_FIXED_FRS_CURR_SHIFT) & 3);
}
static DEVICE_ATTR_RO(fast_role_swap_current);