create_tpm2_key: correct error check

There's no check that we actually have a last argument and the check
to see if we have too many is wrong.  All of this needs to be relative
to optind, so if optind != argc-1 we don't have the final file name.

Signed-off-by: James Bottomley <James.Bottomley@HansenPartnership.com>

1 files changed, 6 insertions, 1 deletions

diff --git a/create_tpm2_key.c b/create_tpm2_key.c
index b99166c..3970333 100644
--- a/create_tpm2_key.c
+++ b/create_tpm2_key.c
@@ -694,9 +694,14 @@ int main(int argc, char **argv)
 		}
 	}
 
+	if (optind >= argc) {
+		printf("Too few arguments: Expected file name as last argument\n");
+		usage(argv[0]);
+	}
+
 	filename = argv[argc - 1];
 
-	if (argc < 2) {
+	if (optind < argc - 1) {
 		printf("Unexpected additional arguments\n");
 		usage(argv[0]);
 	}