aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorZheng Wang <zyytlz.wz@163.com>2023-03-09 00:45:01 +0800
committerLuiz Augusto von Dentz <luiz.von.dentz@intel.com>2023-04-10 10:23:01 -0700
commit73f7b171b7c09139eb3c6a5677c200dc1be5f318 (patch)
treed231eddc6d2705bac3eca408fc9d6259f7c680d8
parentc95930abd687fcd1aa040dc4fe90dff947916460 (diff)
downloadnvme-73f7b171b7c09139eb3c6a5677c200dc1be5f318.tar.gz
Bluetooth: btsdio: fix use after free bug in btsdio_remove due to race condition
In btsdio_probe, the data->work is bound with btsdio_work. It will be started in btsdio_send_frame. If the btsdio_remove runs with a unfinished work, there may be a race condition that hdev is freed but used in btsdio_work. Fix it by canceling the work before do cleanup in btsdio_remove. Signed-off-by: Zheng Wang <zyytlz.wz@163.com> Signed-off-by: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
-rw-r--r--drivers/bluetooth/btsdio.c1
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/bluetooth/btsdio.c b/drivers/bluetooth/btsdio.c
index 02893600db3904..51000320e1ea89 100644
--- a/drivers/bluetooth/btsdio.c
+++ b/drivers/bluetooth/btsdio.c
@@ -358,6 +358,7 @@ static void btsdio_remove(struct sdio_func *func)
if (!data)
return;
+ cancel_work_sync(&data->work);
hdev = data->hdev;
sdio_set_drvdata(func, NULL);