summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorXiao Ni <xni@redhat.com>2020-07-27 09:14:20 +0800
committerJes Sorensen <jsorensen@fb.com>2020-08-07 09:46:03 -0400
commit138a9e9bbe2622eafc90c976b82f3d84895dbebd (patch)
tree9e908ab634b25c155b5d379aa6c9216cb6bb12e8
parent77b72fa828132a35c8b2e08d3fb07eea80b11895 (diff)
downloadmdadm-138a9e9bbe2622eafc90c976b82f3d84895dbebd.tar.gz
Specify nodes number when updating cluster nodes
Now it allows updating cluster nodes without specify --nodes. It can write superblock with zero nodes. It can break the current cluster. Add this check to avoid this problem. v2: It needs check c.update first to avoid NULL pointer reference v3: Wol points the typo error Signed-off-by: Xiao Ni <xni@redhat.com> Signed-off-by: Jes Sorensen <jsorensen@fb.com>
-rw-r--r--mdadm.c5
1 files changed, 5 insertions, 0 deletions
diff --git a/mdadm.c b/mdadm.c
index 13dc24e4..1b3467fd 100644
--- a/mdadm.c
+++ b/mdadm.c
@@ -1433,6 +1433,11 @@ int main(int argc, char *argv[])
}
}
+ if (c.update && strcmp(c.update, "nodes") == 0 && c.nodes == 0) {
+ pr_err("Please specify nodes number with --nodes\n");
+ exit(1);
+ }
+
if (c.backup_file && data_offset != INVALID_SECTORS) {
pr_err("--backup-file and --data-offset are incompatible\n");
exit(2);