aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorMarkus Elfring <elfring@users.sourceforge.net>2015-11-23 20:16:45 +0100
committerIlya Dryomov <idryomov@gmail.com>2016-01-21 19:36:07 +0100
commit1761b22966e61494f51be76bc3b10e9c1ff809ad (patch)
tree991aad505b999c9fe87a32c5e6188d2cee10866e
parent17ddc49b9c5c8847be745d13d91259248d59114b (diff)
downloadnvdimm-1761b22966e61494f51be76bc3b10e9c1ff809ad.tar.gz
rbd: delete an unnecessary check before rbd_dev_destroy()
The rbd_dev_destroy() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring <elfring@users.sourceforge.net> Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
-rw-r--r--drivers/block/rbd.c3
1 files changed, 1 insertions, 2 deletions
diff --git a/drivers/block/rbd.c b/drivers/block/rbd.c
index 81ea69fee7ca18..4a876785b68cd5 100644
--- a/drivers/block/rbd.c
+++ b/drivers/block/rbd.c
@@ -5185,8 +5185,7 @@ static int rbd_dev_probe_parent(struct rbd_device *rbd_dev, int depth)
out_err:
rbd_dev_unparent(rbd_dev);
- if (parent)
- rbd_dev_destroy(parent);
+ rbd_dev_destroy(parent);
return ret;
}