diff options
| author | Maurizio Lombardi <mlombard@redhat.com> | 2023-11-23 15:07:41 +0100 |
|---|---|---|
| committer | Keith Busch <kbusch@kernel.org> | 2023-11-27 10:26:43 -0800 |
| commit | e3139cef8257fcab1725441e2fd5fd0ccb5481b1 (patch) | |
| tree | 9ec04a8124356d1871a29a581906ed3be3e51158 | |
| parent | 136cfcb8dce9bc7a17a8d32e497f4dfe80dd357d (diff) | |
| download | linux-xfs-e3139cef8257fcab1725441e2fd5fd0ccb5481b1.tar.gz | |
nvme-core: fix a memory leak in nvme_ns_info_from_identify()
In case of error, free the nvme_id_ns structure that was allocated
by nvme_identify_ns().
Signed-off-by: Maurizio Lombardi <mlombard@redhat.com>
Reviewed-by: Sagi Grimberg <sagi@grimberg.me>
Reviewed-by: Kanchan Joshi <joshi.k@samsung.com>
Signed-off-by: Keith Busch <kbusch@kernel.org>
| -rw-r--r-- | drivers/nvme/host/core.c | 7 |
1 files changed, 5 insertions, 2 deletions
diff --git a/drivers/nvme/host/core.c b/drivers/nvme/host/core.c index 8bf24c1cd8bba..af94d067ac140 100644 --- a/drivers/nvme/host/core.c +++ b/drivers/nvme/host/core.c @@ -1487,7 +1487,8 @@ static int nvme_ns_info_from_identify(struct nvme_ctrl *ctrl, if (id->ncap == 0) { /* namespace not allocated or attached */ info->is_removed = true; - return -ENODEV; + ret = -ENODEV; + goto error; } info->anagrpid = id->anagrpid; @@ -1505,8 +1506,10 @@ static int nvme_ns_info_from_identify(struct nvme_ctrl *ctrl, !memchr_inv(ids->nguid, 0, sizeof(ids->nguid))) memcpy(ids->nguid, id->nguid, sizeof(ids->nguid)); } + +error: kfree(id); - return 0; + return ret; } static int nvme_ns_info_from_id_cs_indep(struct nvme_ctrl *ctrl, |