diff options
| author | Hou Tao <houtao1@huawei.com> | 2023-11-11 12:38:21 +0800 |
|---|---|---|
| committer | Alexei Starovoitov <ast@kernel.org> | 2023-11-26 18:00:26 -0800 |
| commit | 75a442581d05edaee168222ffbe00d4389785636 (patch) | |
| tree | 6e7f8564ef1db21b3c0ab3e335142df1d53a6065 | |
| parent | c0c6bde586c7dce82719b4ff32a2db6af9ee3d65 (diff) | |
| download | linux-xfs-75a442581d05edaee168222ffbe00d4389785636.tar.gz | |
bpf: Add missed allocation hint for bpf_mem_cache_alloc_flags()
bpf_mem_cache_alloc_flags() may call __alloc() directly when there is no
free object in free list, but it doesn't initialize the allocation hint
for the returned pointer. It may lead to bad memory dereference when
freeing the pointer, so fix it by initializing the allocation hint.
Fixes: 822fb26bdb55 ("bpf: Add a hint to allocated objects.")
Signed-off-by: Hou Tao <houtao1@huawei.com>
Acked-by: Yonghong Song <yonghong.song@linux.dev>
Link: https://lore.kernel.org/r/20231111043821.2258513-1-houtao@huaweicloud.com
Signed-off-by: Alexei Starovoitov <ast@kernel.org>
| -rw-r--r-- | kernel/bpf/memalloc.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/kernel/bpf/memalloc.c b/kernel/bpf/memalloc.c index 63b909d277d479..6a51cfe4c2d63f 100644 --- a/kernel/bpf/memalloc.c +++ b/kernel/bpf/memalloc.c @@ -978,6 +978,8 @@ void notrace *bpf_mem_cache_alloc_flags(struct bpf_mem_alloc *ma, gfp_t flags) memcg = get_memcg(c); old_memcg = set_active_memcg(memcg); ret = __alloc(c, NUMA_NO_NODE, GFP_KERNEL | __GFP_NOWARN | __GFP_ACCOUNT); + if (ret) + *(struct bpf_mem_cache **)ret = c; set_active_memcg(old_memcg); mem_cgroup_put(memcg); } |