aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorOGAWA Hirofumi <hirofumi@mail.parknet.co.jp>2013-01-23 02:27:06 +0900
committerDaniel Phillips <daniel@tux3.org>2013-01-23 02:27:06 +0900
commit26f4917d459d5db77141181c435379c396d00a10 (patch)
tree486cfd203c43acc9245320a7b7d5a0be09e14f23
parent0a13fc6081dea3a8777317ca447c3c7fc9f4e946 (diff)
downloadlinux-tux3-26f4917d459d5db77141181c435379c396d00a10.tar.gz
tux3: Add FIXME for future optimization case for __tux3_write_begin()
Signed-off-by: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
-rw-r--r--fs/tux3/filemap_blocklib.c6
1 files changed, 6 insertions, 0 deletions
diff --git a/fs/tux3/filemap_blocklib.c b/fs/tux3/filemap_blocklib.c
index e17aae9f651fc7..c90dae45d22f42 100644
--- a/fs/tux3/filemap_blocklib.c
+++ b/fs/tux3/filemap_blocklib.c
@@ -95,6 +95,12 @@ static int __tux3_write_begin(struct page *page, loff_t pos, unsigned len,
if (buffer_new(bh))
clear_buffer_new(bh);
if (!buffer_mapped(bh)) {
+ /*
+ * FIXME: If user overwrites block fully, we
+ * don't need get_block(). Since we know it is
+ * delayed allocation, so, we can use SEG_HOLE
+ * as delayed allocation.
+ */
WARN_ON(bh->b_size != blocksize);
err = get_block(inode, block, bh, 1);
if (err)