server/parser: Make sure the XSLT parameter array is always cleared before use

Signed-off-by: David Sommerseth <davids@redhat.com>

1 files changed, 4 insertions, 1 deletions

diff --git a/server/parser/xmlparser.c b/server/parser/xmlparser.c
index 2ba7288..059dd79 100644
--- a/server/parser/xmlparser.c
+++ b/server/parser/xmlparser.c
@@ -211,10 +211,12 @@ void init_xmlparser(dbhelper_func const * dbhelpers)
  */
 xmlDoc *parseToSQLdata(LogContext *log, xsltStylesheet *xslt, xmlDoc *indata_d, parseParams *params) {
         xmlDoc *result_d = NULL;
-        char *xsltparams[10];
+        char **xsltparams = NULL;
         unsigned int idx = 0, idx_table = 0, idx_submid = 0,
 		idx_syskey = 0, idx_rterid = 0, idx_repfname = 0;
 
+        xsltparams = calloc(10, sizeof(char *));
+
         if( xmlparser_dbhelpers == NULL ) {
                 writelog(log, LOG_ERR, "Programming error: xmlparser is not initialised");
                 return NULL;
@@ -276,6 +278,7 @@ xmlDoc *parseToSQLdata(LogContext *log, xsltStylesheet *xslt, xmlDoc *indata_d,
                 free(xsltparams[idx_repfname]);
         }
 
+        free(xsltparams);
         return result_d;
 }