diff options
| author | Brett Mastbergen <brett.mastbergen@gmail.com> | 2020-12-08 16:39:24 -0500 |
|---|---|---|
| committer | Pablo Neira Ayuso <pablo@netfilter.org> | 2020-12-09 10:31:58 +0100 |
| commit | 2d94b20b95b009eec1a267dcf026b01af627c0cd (patch) | |
| tree | b90bed322948a1eb53823d2b4d293f0224445d17 | |
| parent | 42f1c27120906a54e73101a7d6a12f58813f6a9f (diff) | |
| download | linux-2d94b20b95b009eec1a267dcf026b01af627c0cd.tar.gz | |
netfilter: nft_ct: Remove confirmation check for NFT_CT_ID
Since commit 656c8e9cc1ba ("netfilter: conntrack: Use consistent ct id
hash calculation") the ct id will not change from initialization to
confirmation. Removing the confirmation check allows for things like
adding an element to a 'typeof ct id' set in prerouting upon reception
of the first packet of a new connection, and then being able to
reference that set consistently both before and after the connection
is confirmed.
Fixes: 656c8e9cc1ba ("netfilter: conntrack: Use consistent ct id hash calculation")
Signed-off-by: Brett Mastbergen <brett.mastbergen@gmail.com>
Acked-by: Florian Westphal <fw@strlen.de>
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
| -rw-r--r-- | net/netfilter/nft_ct.c | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/net/netfilter/nft_ct.c b/net/netfilter/nft_ct.c index 322bd674963ee0..a1b0aac46e9e03 100644 --- a/net/netfilter/nft_ct.c +++ b/net/netfilter/nft_ct.c @@ -177,8 +177,6 @@ static void nft_ct_get_eval(const struct nft_expr *expr, } #endif case NFT_CT_ID: - if (!nf_ct_is_confirmed(ct)) - goto err; *dest = nf_ct_get_id(ct); return; default: |