diff options
| author | Darrick J. Wong <djwong@kernel.org> | 2023-05-24 15:03:58 -0700 |
|---|---|---|
| committer | Carlos Maiolino <cem@kernel.org> | 2023-06-07 17:14:09 +0200 |
| commit | 0b54810415bd9e65b4b7b6c737d0bd96e32bc8a2 (patch) | |
| tree | b4c30b01710999bafdbff2dffd0c99455bcae5b2 | |
| parent | ee49b90f5d7050e333b83577103fa95a3e467910 (diff) | |
| download | xfsprogs-dev-pull_request_tests.tar.gz | |
xfs_repair: fix messaging when fixing imap due to sparse clusterpull_request_tests
This logic is wrong -- if we're in verbose dry-run mode, we do NOT want
to say that we're correcting the imap. Otherwise, we print things like:
imap claims inode XXX is present, but inode cluster is sparse,
But then we can erroneously tell the user that we would correct the
imap when in fact we /are/ correcting it.
Fixes: f4ff8086586 ("xfs_repair: don't crash on partially sparse inode clusters")
Signed-off-by: Darrick J. Wong <djwong@kernel.org>
Signed-off-by: Carlos Maiolino <cem@kernel.org>
| -rw-r--r-- | repair/dino_chunks.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/repair/dino_chunks.c b/repair/dino_chunks.c index 3300885378..171756818a 100644 --- a/repair/dino_chunks.c +++ b/repair/dino_chunks.c @@ -834,7 +834,7 @@ next_readbuf: do_warn( _("imap claims inode %" PRIu64 " is present, but inode cluster is sparse, "), ino); - if (verbose || !no_modify) + if (!no_modify) do_warn(_("correcting imap\n")); else do_warn(_("would correct imap\n")); |