diff options
| author | Dan Carpenter <dan.carpenter@oracle.com> | 2018-01-25 17:27:27 +0300 |
|---|---|---|
| committer | Ben Hutchings <ben@decadent.org.uk> | 2020-06-11 19:05:41 +0100 |
| commit | b79b2c774d18d9f742c6dee7c8af3d8fd75d1852 (patch) | |
| tree | 0ccf1d252b7c55ace7c3fc6c40f2635d8a86f67b | |
| parent | 575f200adca1fe48df15063b1a5673a9b5f713bd (diff) | |
| download | linux-stable-b79b2c774d18d9f742c6dee7c8af3d8fd75d1852.tar.gz | |
scsi: mptfusion: Add bounds check in mptctl_hp_targetinfo()
commit a7043e9529f3c367cc4d82997e00be034cbe57ca upstream.
My static checker complains about an out of bounds read:
drivers/message/fusion/mptctl.c:2786 mptctl_hp_targetinfo()
error: buffer overflow 'hd->sel_timeout' 255 <= u32max.
It's true that we probably should have a bounds check here.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Johannes Thumshirn <jthumshirn@suse.de>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
| -rw-r--r-- | drivers/message/fusion/mptctl.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/drivers/message/fusion/mptctl.c b/drivers/message/fusion/mptctl.c index 8a050e8856881..cac8b0187295d 100644 --- a/drivers/message/fusion/mptctl.c +++ b/drivers/message/fusion/mptctl.c @@ -2698,6 +2698,8 @@ mptctl_hp_targetinfo(unsigned long arg) __FILE__, __LINE__, iocnum); return -ENODEV; } + if (karg.hdr.id >= MPT_MAX_FC_DEVICES) + return -EINVAL; dctlprintk(ioc, printk(MYIOC_s_DEBUG_FMT "mptctl_hp_targetinfo called.\n", ioc->name)); |