diff options
| author | Dan Carpenter <dan.carpenter@oracle.com> | 2019-09-25 14:01:28 +0300 |
|---|---|---|
| committer | Ben Hutchings <ben@decadent.org.uk> | 2020-05-22 21:19:26 +0100 |
| commit | 3cae91b92588ed781c75c090fa8c17b9f9178a9a (patch) | |
| tree | 52f070b78f294eaedeb24168b710a17a71d56299 | |
| parent | be5ffa1844d2bbac08d0d89fa8569f1022962583 (diff) | |
| download | linux-stable-3cae91b92588ed781c75c090fa8c17b9f9178a9a.tar.gz | |
power: supply: sbs-battery: Fix a signedness bug in sbs_get_battery_capacity()
commit eb368de6de32925c65a97c1e929a31cae2155aee upstream.
The "mode" variable is an enum and in this context GCC treats it as an
unsigned int so the error handling is never triggered.
Fixes: 51d075660457 ("bq20z75: Add support for charge properties")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>
[bwh: Backported to 3.16: adjust filename, context]
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
| -rw-r--r-- | drivers/power/sbs-battery.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/power/sbs-battery.c b/drivers/power/sbs-battery.c index b5f2a76b6cdf9..32553c23d4676 100644 --- a/drivers/power/sbs-battery.c +++ b/drivers/power/sbs-battery.c @@ -400,7 +400,7 @@ static int sbs_get_battery_capacity(struct i2c_client *client, mode = BATTERY_MODE_AMPS; mode = sbs_set_battery_mode(client, mode); - if (mode < 0) + if ((int)mode < 0) return mode; ret = sbs_read_word_data(client, sbs_data[reg_offset].addr); |