diff options
| author | Dai Shili <daisl.fnst@fujitsu.com> | 2022-03-25 16:04:12 -0400 |
|---|---|---|
| committer | Eryu Guan <guaneryu@gmail.com> | 2022-04-10 23:16:44 +0800 |
| commit | b5660918c9826f62934469b3b61d9e1c920288d3 (patch) | |
| tree | c4dcf32367e4f63aa002c1a2e58362685fad19e0 | |
| parent | 513338e6a74342d5614c7a27b278f0195e42a12f (diff) | |
| download | xfstests-dev-b5660918c9826f62934469b3b61d9e1c920288d3.tar.gz | |
generic/631: use trusted.* extended attributes to filter NFS filesystem
Since commit 2461e8901c ("generic/631: Add a check for extended
attributes"), check of user.* extended attributes was added to avoid
running this tests for filesystems that are not supported.
But it still fails on NFSv4.2 when mount overlayfs with the
following error.
/var/mnt/scratch/merged0: wrong fs type, bad option, bad superblock
on overlay, missing codepage or helper program, or other error.
dmesg log reports the following -
overlayfs: upper fs does not support xattr, falling back to index=off and metacopy=off.
As per the linux patch series(https://lwn.net/Articles/799185/ ), the
support of user extended attributes were added to NFSv4.2. So this
case passed the check of extended attributes by _require_attrs.
As per the overlayfs documentation -
"The upper filesystem will normally be writable and if it is it must
support the creation of trusted.* and/or user.* extended attributes,
and must provide valid d_type in readdir responses, so NFS is not
suitable."
So we can replace user.* extended attributes check with trusted.* to
filter NFS filesystem.
Signed-off-by: Dai Shili <daisl.fnst@fujitsu.com>
Reviewed-by: Eryu Guan <guaneryu@gmail.com>
Signed-off-by: Eryu Guan <guaneryu@gmail.com>
| -rwxr-xr-x | tests/generic/631 | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/tests/generic/631 b/tests/generic/631 index aae181dd2d..4996bce705 100755 --- a/tests/generic/631 +++ b/tests/generic/631 @@ -38,7 +38,7 @@ _cleanup() # real QA test starts here _supported_fs generic _require_scratch -_require_attrs +_require_attrs trusted test "$FSTYP" = "overlay" && _notrun "Test does not apply to overlayfs." _require_extra_fs overlay |