diff options
author | Shin'ichiro Kawasaki <shinichiro.kawasaki@wdc.com> | 2024-04-30 19:30:20 +0900 |
---|---|---|
committer | Vincent Fu <vincent.fu@samsung.com> | 2024-04-30 11:11:58 -0400 |
commit | 0c9c3a9b053b47543e38dd7242b9bfdf30f851e6 (patch) | |
tree | 741945e97b35f3f4fa97751d6067951972bb8b0f | |
parent | 6a9a9bd2c524a7ef58d2fb8181038408155902b8 (diff) | |
download | fio-0c9c3a9b053b47543e38dd7242b9bfdf30f851e6.tar.gz |
zbd: remove unnecessary verify_backlog check in zbd_file_reset()
The commit c5c8b92be5a2 ("zbd: fix zone reset condition for verify")
improved zbd_file_reset() to not reset zones when data to verify is
left. To check the left verify data, it tried to do the same as
check_get_verify() including the check for the modulo operation
"td->io_hist_len % td->o.verify_backlog". This check is required in
check_get_verify() to know when to do the verify backlog operation.
However, this check is not required in zbd_file_reset() since zone reset
is not related to the verify backlog timing. The unnecessary check for
"td->io_hist_len % td->o.verify_backlog" allows to reset zones even when
td->io_hist_len is non-zero and the data to verify is left. It erases
the data to verify and causes verify errors. Fix this by removing the
unnecessary check.
Fixes: c5c8b92be5a2 ("zbd: fix zone reset condition for verify")
Signed-off-by: Shin'ichiro Kawasaki <shinichiro.kawasaki@wdc.com>
Link: https://lore.kernel.org/r/20240430103022.4136039-2-shinichiro.kawasaki@wdc.com
Signed-off-by: Vincent Fu <vincent.fu@samsung.com>
-rw-r--r-- | zbd.c | 3 |
1 files changed, 0 insertions, 3 deletions
@@ -1361,9 +1361,6 @@ void zbd_file_reset(struct thread_data *td, struct fio_file *f) if (td->o.verify != VERIFY_NONE) { verify_data_left = td->runstate == TD_VERIFYING || td->io_hist_len || td->verify_batch; - if (td->io_hist_len && td->o.verify_backlog) - verify_data_left = - td->io_hist_len % td->o.verify_backlog; if (!verify_data_left) zbd_reset_zones(td, f, zb, ze); } |