aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorAndrew G. Morgan <morgan@kernel.org>2022-05-17 07:10:19 -0700
committerAndrew G. Morgan <morgan@kernel.org>2022-05-17 07:10:19 -0700
commit52288ccc0b341cc4ce2751accca467ee1cc67389 (patch)
treeab45403fb64e547199dd1050a0b190a0ab3a67ba
parenteb0f1df722d5e760137a0dd85fee8e78c95ee68f (diff)
downloadlibcap-52288ccc0b341cc4ce2751accca467ee1cc67389.tar.gz
Close out this comment in the go/Makefile
The deadlock issue is fixed in go1.18. Signed-off-by: Andrew G. Morgan <morgan@kernel.org>
-rw-r--r--go/Makefile5
1 files changed, 4 insertions, 1 deletions
diff --git a/go/Makefile b/go/Makefile
index 109581b..f6390da 100644
--- a/go/Makefile
+++ b/go/Makefile
@@ -86,7 +86,10 @@ endif
# This is a test case developed from the deadlock investigation,
# https://github.com/golang/go/issues/50113 . Note the psx-fd.go code
# works when compiled CGO_ENABLED=1, but deadlocks when compiled
-# CGO_ENABLED=0. At the time of writing, this is true for go1.16+.
+# CGO_ENABLED=0. This is true for go1.16 and go1.17. The go1.18
+# release fixed this by rewriting the AllThreadsSyscall support, but
+# the large change was not backported. (See noted bug for a much
+# smaller patch for this issue on those older releases.)
psx-fd: psx-fd.go PSXGOPACKAGE
CC="$(CC)" CGO_ENABLED="$(CGO_REQUIRED)" $(CGO_LDFLAGS_ALLOW) $(GO) build $(GO_BUILD_FLAGS) -mod=vendor -o $@ $<