diff options
| author | Matan Barak <matanb@mellanox.com> | 2016-03-14 12:59:06 +0200 |
|---|---|---|
| committer | Doug Ledford <dledford@redhat.com> | 2016-03-17 09:48:03 -0400 |
| commit | ffb784b9514ed55bb70136b04ff3ee42901f8136 (patch) | |
| tree | f442b098dd5e37b35295791819ff2887420096b6 | |
| parent | f224da05def54b46ef51ca6a21c6bf8ce72d2ebe (diff) | |
| download | libibverbs-ffb784b9514ed55bb70136b04ff3ee42901f8136.tar.gz | |
Change rereg_mr API between libibverbs and the provider's library
Currently, MR re-registration isn't implemented in libibverbs.
The only part which does exist is an API call between libibverbs
and the provider's library. Since there's no way for a user application
to invoke this API call, it's safe to assume it's unused.
Similarly to other verbs (for example, ibv_modify_qp), a modification
to the MR shouldn't change the user's handle. The current existing API is:
struct ibv_mr * (*rereg_mr)(struct ibv_mr *mr,
int flags,
struct ibv_pd *pd, void *addr,
size_t length,
int access);
As a result, this API call returns the exact same pointer it gets.
Instead, we propose retuning a status int, which is far more useful
than the current return value.
Signed-off-by: Matan Barak <matanb@mellanox.com>
Reviewed-by: Yishai Hadas <yishaih@mellanox.com>
Signed-off-by: Doug Ledford <dledford@redhat.com>
| -rw-r--r-- | include/infiniband/verbs.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/include/infiniband/verbs.h b/include/infiniband/verbs.h index d0c2969..709926d 100644 --- a/include/infiniband/verbs.h +++ b/include/infiniband/verbs.h @@ -983,7 +983,7 @@ struct ibv_context_ops { int (*dealloc_pd)(struct ibv_pd *pd); struct ibv_mr * (*reg_mr)(struct ibv_pd *pd, void *addr, size_t length, int access); - struct ibv_mr * (*rereg_mr)(struct ibv_mr *mr, + int (*rereg_mr)(struct ibv_mr *mr, int flags, struct ibv_pd *pd, void *addr, size_t length, |