diff options
| author | Jeff King <peff@peff.net> | 2020-04-10 15:44:45 -0400 |
|---|---|---|
| committer | Junio C Hamano <gitster@pobox.com> | 2020-04-10 14:47:36 -0700 |
| commit | 6c7e6963c1b6d9a5344345d55dd537e4ab45158f (patch) | |
| tree | b66a00a9f0ef5a1ef76ad5bd5947cb6dcbfde85f /config.c | |
| parent | f5914f4b6bcdb517733c761fe5ba9d94471eb01d (diff) | |
| download | git-6c7e6963c1b6d9a5344345d55dd537e4ab45158f.tar.gz | |
config: drop useless length variable in write_pair()
We compute the length of a subset of a string, but then use that length
only to feed a "%.*s" printf placeholder for the same string. We can
just use "%s" to achieve the same thing.
The variable became useless in cb891a5989 (Use a strbuf for building up
section header and key/value pair strings., 2007-12-14), which swapped
out a write() which _did_ use the length for a strbuf_addf() call.
Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'config.c')
| -rw-r--r-- | config.c | 4 |
1 files changed, 1 insertions, 3 deletions
@@ -2545,7 +2545,6 @@ static ssize_t write_pair(int fd, const char *key, const char *value, { int i; ssize_t ret; - int length = strlen(key + store->baselen + 1); const char *quote = ""; struct strbuf sb = STRBUF_INIT; @@ -2564,8 +2563,7 @@ static ssize_t write_pair(int fd, const char *key, const char *value, if (i && value[i - 1] == ' ') quote = "\""; - strbuf_addf(&sb, "\t%.*s = %s", - length, key + store->baselen + 1, quote); + strbuf_addf(&sb, "\t%s = %s", key + store->baselen + 1, quote); for (i = 0; value[i]; i++) switch (value[i]) { |