aboutsummaryrefslogtreecommitdiffstats
path: root/builtin
diff options
context:
space:
mode:
authorRubén Justo <rjusto@gmail.com>2024-02-14 00:36:38 +0100
committerJunio C Hamano <gitster@pobox.com>2024-02-14 10:16:40 -0800
commit92e66478fc0f1e03ff8e49d66ebe84b1d98b7a90 (patch)
tree21f2013d2344d4f61145e0687d29a91c5fa274d5 /builtin
parent0d1bd1dfb37ef25e1911777c94129fc769ffec38 (diff)
downloadgit-92e66478fc0f1e03ff8e49d66ebe84b1d98b7a90.tar.gz
tag: error when git-column fails
If the user asks for the list of tags to be displayed in columns ("--columns"), a child git-column process is used to format the output as expected. In a rare situation where we encounter a problem spawning that child process, we will work erroneously. Make noticeable we're having a problem executing git-column, so the user can act accordingly. Signed-off-by: Rubén Justo <rjusto@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'builtin')
-rw-r--r--builtin/tag.c3
1 files changed, 2 insertions, 1 deletions
diff --git a/builtin/tag.c b/builtin/tag.c
index d428c45dc8..53f8bfd907 100644
--- a/builtin/tag.c
+++ b/builtin/tag.c
@@ -537,7 +537,8 @@ int cmd_tag(int argc, const char **argv, const char *prefix)
struct column_options copts;
memset(&copts, 0, sizeof(copts));
copts.padding = 2;
- run_column_filter(colopts, &copts);
+ if (run_column_filter(colopts, &copts))
+ die(_("could not start 'git column'"));
}
filter.name_patterns = argv;
ret = list_tags(&filter, sorting, &format);