diff options
| author | Eric Biggers <ebiggers@google.com> | 2024-04-30 19:53:31 -0700 |
|---|---|---|
| committer | Eric Biggers <ebiggers@google.com> | 2024-05-03 08:30:58 -0700 |
| commit | ee5814dddefbaa181cb247a75676dd5103775db1 (patch) | |
| tree | d84ec395359072947cfec2811c70486c873fc173 | |
| parent | e67572cd2204894179d89bd7b984072f19313b03 (diff) | |
| download | linux-for-next.tar.gz | |
fsverity: use register_sysctl_init() to avoid kmemleak warningHEADfsverity-for-linusfor-next
Since the fsverity sysctl registration runs as a builtin initcall, there
is no corresponding sysctl deregistration and the resulting struct
ctl_table_header is not used. This can cause a kmemleak warning just
after the system boots up. (A pointer to the ctl_table_header is stored
in the fsverity_sysctl_header static variable, which kmemleak should
detect; however, the compiler can optimize out that variable.) Avoid
the kmemleak warning by using register_sysctl_init() which is intended
for use by builtin initcalls and uses kmemleak_not_leak().
Reported-by: Yi Zhang <yi.zhang@redhat.com>
Closes: https://lore.kernel.org/r/CAHj4cs8DTSvR698UE040rs_pX1k-WVe7aR6N2OoXXuhXJPDC-w@mail.gmail.com
Cc: stable@vger.kernel.org
Reviewed-by: Joel Granados <j.granados@samsung.com>
Link: https://lore.kernel.org/r/20240501025331.594183-1-ebiggers@kernel.org
Signed-off-by: Eric Biggers <ebiggers@google.com>
| -rw-r--r-- | fs/verity/init.c | 7 |
1 files changed, 1 insertions, 6 deletions
diff --git a/fs/verity/init.c b/fs/verity/init.c index cb2c9aac61ed0a..f440f0e61e3e6c 100644 --- a/fs/verity/init.c +++ b/fs/verity/init.c @@ -10,8 +10,6 @@ #include <linux/ratelimit.h> #ifdef CONFIG_SYSCTL -static struct ctl_table_header *fsverity_sysctl_header; - static struct ctl_table fsverity_sysctl_table[] = { #ifdef CONFIG_FS_VERITY_BUILTIN_SIGNATURES { @@ -28,10 +26,7 @@ static struct ctl_table fsverity_sysctl_table[] = { static void __init fsverity_init_sysctl(void) { - fsverity_sysctl_header = register_sysctl("fs/verity", - fsverity_sysctl_table); - if (!fsverity_sysctl_header) - panic("fsverity sysctl registration failed"); + register_sysctl_init("fs/verity", fsverity_sysctl_table); } #else /* CONFIG_SYSCTL */ static inline void fsverity_init_sysctl(void) |