aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorSteve French <stfrench@microsoft.com>2021-09-20 19:01:42 -0500
committerSteve French <stfrench@microsoft.com>2021-09-21 12:35:20 -0500
commite44fd5081c50b0ffdb75ce6c83452e60173d791b (patch)
tree812339f0f948f7bdf975a1c666fc74b955372395
parent707a63e9a9dd55432d47bf40457d4a3413888dcc (diff)
downloadlinux-e44fd5081c50b0ffdb75ce6c83452e60173d791b.tar.gz
ksmbd: log that server is experimental at module load
While we are working through detailed security reviews of ksmbd server code we should remind users that it is an experimental module by adding a warning when the module loads. Currently the module shows as experimental in Kconfig and is disabled by default, but we don't want to confuse users. Although ksmbd passes a wide variety of the important functional tests (since initial focus had been largely on functional testing such as smbtorture, xfstests etc.), and ksmbd has added key security features (e.g. GCM256 encryption, Kerberos support), there are ongoing detailed reviews of the code base for path processing and network buffer decoding, and this patch reminds users that the module should be considered "experimental." Reviewed-by: Namjae Jeon <linkinjeon@kernel.org> Reviewed-by: Paulo Alcantara (SUSE) <pc@cjr.nz> Reviewed-by: Ronnie Sahlberg <lsahlber@redhat.com> Signed-off-by: Steve French <stfrench@microsoft.com>
-rw-r--r--fs/ksmbd/server.c3
1 files changed, 3 insertions, 0 deletions
diff --git a/fs/ksmbd/server.c b/fs/ksmbd/server.c
index e6a9f6aa47ebbe..2a2b2135bfdede 100644
--- a/fs/ksmbd/server.c
+++ b/fs/ksmbd/server.c
@@ -584,6 +584,9 @@ static int __init ksmbd_server_init(void)
ret = ksmbd_workqueue_init();
if (ret)
goto err_crypto_destroy;
+
+ pr_warn_once("The ksmbd server is experimental, use at your own risk.\n");
+
return 0;
err_crypto_destroy: