diff options
| author | Sebastian Andrzej Siewior <bigeasy@linutronix.de> | 2016-01-13 14:09:05 +0100 |
|---|---|---|
| committer | Sebastian Andrzej Siewior <bigeasy@linutronix.de> | 2016-02-13 00:36:09 +0100 |
| commit | 8629c2aa0455f730699ea371dce2e90bd72377d2 (patch) | |
| tree | 124ff047d20a4e9b35358b79d77369cb8f528543 | |
| parent | ef6ac8404f8c8d1e19fca892a79004e936da3411 (diff) | |
| download | rt-linux-8629c2aa0455f730699ea371dce2e90bd72377d2.tar.gz | |
ptrace: don't open IRQs in ptrace_freeze_traced() too early
In the non-RT case the spin_lock_irq() here disables interrupts as well
as raw_spin_lock_irq(). So in the unlock case the interrupts are enabled
too early.
Reported-by: kernel test robot <ying.huang@linux.intel.com>
Cc: stable-rt@vger.kernel.org
Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
| -rw-r--r-- | kernel/ptrace.c | 6 |
1 files changed, 4 insertions, 2 deletions
diff --git a/kernel/ptrace.c b/kernel/ptrace.c index d1d158005ad06..2856b433d9d6f 100644 --- a/kernel/ptrace.c +++ b/kernel/ptrace.c @@ -129,12 +129,14 @@ static bool ptrace_freeze_traced(struct task_struct *task) spin_lock_irq(&task->sighand->siglock); if (task_is_traced(task) && !__fatal_signal_pending(task)) { - raw_spin_lock_irq(&task->pi_lock); + unsigned long flags; + + raw_spin_lock_irqsave(&task->pi_lock, flags); if (task->state & __TASK_TRACED) task->state = __TASK_TRACED; else task->saved_state = __TASK_TRACED; - raw_spin_unlock_irq(&task->pi_lock); + raw_spin_unlock_irqrestore(&task->pi_lock, flags); ret = true; } spin_unlock_irq(&task->sighand->siglock); |