diff options
| author | maximilian attems <max@stro.at> | 2010-07-07 13:42:59 +0200 |
|---|---|---|
| committer | maximilian attems <max@stro.at> | 2010-07-07 14:06:26 +0200 |
| commit | 1e2af5b16918993b0c61b3069f1436ffdfcf2983 (patch) | |
| tree | 3f4ec982ab20851737d49095e5a429aa0f449c98 | |
| parent | 593b0aa4c9fcfbec7780d9a5c02e8f9942f7387e (diff) | |
| download | klibc-1e2af5b16918993b0c61b3069f1436ffdfcf2983.tar.gz | |
[klibc] valgrind: netdev_sif_addr fix unitialized valgrind error
memset struct sockaddr_in sin and thus get a clean valgrind ipconfig run.
Fixes:
==15636== ERROR SUMMARY: 3 errors from 3 contexts (suppressed: 0 from 0)
==15636==
==15636== 1 errors in context 1 of 3:
==15636== Syscall param ioctl(SIOCSIF*ADDR) points to uninitialised byte(s)
==15636== at 0x403EB1: __syscall_common (in /home/maks/src/klibc-latest/usr/kinit/ipconfig/static/ipconfig.g)
==15636== by 0x401859: netdev_setaddress (in /home/maks/src/klibc-latest/usr/kinit/ipconfig/static/ipconfig.g)
==15636== by 0x30687464: ???
==15636== Address 0x7fefffb02 is on thread 1's stack
==15636==
==15636==
==15636== 1 errors in context 2 of 3:
==15636== Syscall param ioctl(SIOCSIF*ADDR) points to uninitialised byte(s)
==15636== at 0x403EB1: __syscall_common (in /home/maks/src/klibc-latest/usr/kinit/ipconfig/static/ipconfig.g)
==15636== by 0x40180D: netdev_setaddress (in /home/maks/src/klibc-latest/usr/kinit/ipconfig/static/ipconfig.g)
==15636== by 0x30687464: ???
==15636== Address 0x7fefffb02 is on thread 1's stack
==15636==
==15636==
==15636== 1 errors in context 3 of 3:
==15636== Syscall param ioctl(SIOCSIF*ADDR) points to uninitialised byte(s)
==15636== at 0x403EB1: __syscall_common (in /home/maks/src/klibc-latest/usr/kinit/ipconfig/static/ipconfig.g)
==15636== by 0x4017C8: netdev_setaddress (in /home/maks/src/klibc-latest/usr/kinit/ipconfig/static/ipconfig.g)
==15636== by 0x30687464: ???
==15636== Address 0x7fefffb02 is on thread 1's stack
==15636==
==15636== ERROR SUMMARY: 3 errors from 3 contexts (suppressed: 0 from 0)
Signed-off-by: maximilian attems <max@stro.at>
| -rw-r--r-- | usr/kinit/ipconfig/netdev.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/usr/kinit/ipconfig/netdev.c b/usr/kinit/ipconfig/netdev.c index 6e3014f78793c..e203d0c69f95c 100644 --- a/usr/kinit/ipconfig/netdev.c +++ b/usr/kinit/ipconfig/netdev.c @@ -43,6 +43,7 @@ static int netdev_sif_addr(struct ifreq *ifr, int cmd, uint32_t addr) { struct sockaddr_in sin; + memset(&sin, 0, sizeof(sin)); sin.sin_family = AF_INET; sin.sin_addr.s_addr = addr; |