From: Jean Tourrilhes From: Stephen Hemminger o [FEATURE] stir4200: netdev_priv and message cleanup Stir4200 driver cleanup's: * use netdev_priv * make sure messages identify the driver * get rid of unneeded message Signed-off-by: Jean Tourrilhes Signed-off-by: Andrew Morton --- 25-akpm/drivers/net/irda/stir4200.c | 30 +++++++++++++----------------- 1 files changed, 13 insertions(+), 17 deletions(-) diff -puN drivers/net/irda/stir4200.c~irda-stir-netdev-and-messages-cleanups drivers/net/irda/stir4200.c --- 25/drivers/net/irda/stir4200.c~irda-stir-netdev-and-messages-cleanups Wed Oct 20 15:54:03 2004 +++ 25-akpm/drivers/net/irda/stir4200.c Wed Oct 20 15:54:39 2004 @@ -581,7 +581,7 @@ static int change_speed(struct stir_cb * */ static int stir_hard_xmit(struct sk_buff *skb, struct net_device *netdev) { - struct stir_cb *stir = netdev->priv; + struct stir_cb *stir = netdev_priv(netdev); netif_stop_queue(netdev); @@ -882,7 +882,7 @@ static void stir_rcv_irq(struct urb *urb */ static int stir_net_open(struct net_device *netdev) { - struct stir_cb *stir = netdev->priv; + struct stir_cb *stir = netdev_priv(netdev); int err; char hwname[16]; @@ -935,7 +935,7 @@ static int stir_net_open(struct net_devi sprintf(hwname, "usb#%d", stir->usbdev->devnum); stir->irlap = irlap_open(netdev, &stir->qos, hwname); if (!stir->irlap) { - err("irlap_open failed"); + err("stir4200: irlap_open failed"); goto err_out5; } @@ -944,7 +944,7 @@ static int stir_net_open(struct net_devi CLONE_FS|CLONE_FILES); if (stir->thr_pid < 0) { err = stir->thr_pid; - err("unable to start kernel thread"); + err("stir4200: unable to start kernel thread"); goto err_out6; } @@ -974,7 +974,7 @@ static int stir_net_open(struct net_devi */ static int stir_net_close(struct net_device *netdev) { - struct stir_cb *stir = netdev->priv; + struct stir_cb *stir = netdev_priv(netdev); /* Stop transmit processing */ netif_stop_queue(netdev); @@ -1003,10 +1003,10 @@ static int stir_net_close(struct net_dev /* * IOCTLs : Extra out-of-band network commands... */ -static int stir_net_ioctl(struct net_device *dev, struct ifreq *rq, int cmd) +static int stir_net_ioctl(struct net_device *netdev, struct ifreq *rq, int cmd) { struct if_irda_req *irq = (struct if_irda_req *) rq; - struct stir_cb *stir = dev->priv; + struct stir_cb *stir = netdev_priv(netdev); int ret = 0; switch (cmd) { @@ -1043,9 +1043,9 @@ static int stir_net_ioctl(struct net_dev /* * Get device stats (for /proc/net/dev and ifconfig) */ -static struct net_device_stats *stir_net_get_stats(struct net_device *dev) +static struct net_device_stats *stir_net_get_stats(struct net_device *netdev) { - struct stir_cb *stir = dev->priv; + struct stir_cb *stir = netdev_priv(netdev); return &stir->stats; } @@ -1071,14 +1071,14 @@ static int stir_probe(struct usb_interfa SET_MODULE_OWNER(net); SET_NETDEV_DEV(net, &intf->dev); - stir = net->priv; + stir = netdev_priv(net); stir->netdev = net; stir->usbdev = dev; stir->usbintf = intf; ret = usb_reset_configuration(dev); if (ret != 0) { - err("usb reset configuration failed"); + err("stir4200: usb reset configuration failed"); goto err_out2; } @@ -1111,7 +1111,7 @@ static int stir_probe(struct usb_interfa if (ret != 0) goto err_out2; - MESSAGE("IrDA: Registered SigmaTel device %s\n", net->name); + info("IrDA: Registered SigmaTel device %s", net->name); usb_set_intfdata(intf, stir); @@ -1181,11 +1181,7 @@ static struct usb_driver irda_driver = { */ static int __init stir_init(void) { - if (usb_register(&irda_driver) < 0) - return -1; - - MESSAGE("SigmaTel support registered\n"); - return 0; + return usb_register(&irda_driver); } module_init(stir_init); _