From: Jesper Juhl Here's a patch with kfree() cleanups for drivers/firmware/efivars.c Patch removes redundant NULL checks before kfree and also makes a small whitespace cleanup - moves two statements on same line to separate lines. Signed-off-by: Jesper Juhl Acked-by: Matt Domsch Signed-off-by: Andrew Morton --- drivers/firmware/efivars.c | 7 ++++--- 1 files changed, 4 insertions(+), 3 deletions(-) diff -puN drivers/firmware/efivars.c~kfree-cleanups-for-drivers-firmware drivers/firmware/efivars.c --- 25/drivers/firmware/efivars.c~kfree-cleanups-for-drivers-firmware 2005-05-09 18:04:55.000000000 -0700 +++ 25-akpm/drivers/firmware/efivars.c 2005-05-09 18:04:55.000000000 -0700 @@ -618,8 +618,8 @@ efivar_create_sysfs_entry(unsigned long new_efivar = kmalloc(sizeof(struct efivar_entry), GFP_KERNEL); if (!short_name || !new_efivar) { - if (short_name) kfree(short_name); - if (new_efivar) kfree(new_efivar); + kfree(short_name); + kfree(new_efivar); return 1; } memset(short_name, 0, short_name_size+1); @@ -644,7 +644,8 @@ efivar_create_sysfs_entry(unsigned long kobj_set_kset_s(new_efivar, vars_subsys); kobject_register(&new_efivar->kobj); - kfree(short_name); short_name = NULL; + kfree(short_name); + short_name = NULL; spin_lock(&efivars_lock); list_add(&new_efivar->list, &efivar_list); _